Skip to content

Hubspot - New Custom Object Property Change #14977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Hubspot - New Custom Object Property Change #14977

merged 2 commits into from
Dec 16, 2024

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Dec 13, 2024

Resolves #14945

Summary by CodeRabbit

  • New Features

    • Introduced a new source component for HubSpot that emits events when a specified property of a custom object is created or updated.
    • Users can monitor custom object properties by specifying the objectSchema and the property.
  • Chores

    • Updated the version of the @pipedream/hubspot package from 0.11.0 to 0.12.0.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:51pm
pipedream-docs ⬜️ Ignored (Inspect) Dec 13, 2024 6:51pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Dec 13, 2024 6:51pm

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The pull request includes an update to the version number of the @pipedream/hubspot package in the package.json file, changing it from 0.11.0 to 0.12.0. Additionally, a new source component named new-custom-object-property-change.mjs has been introduced. This component allows users to monitor specific properties of custom objects in HubSpot, emitting events upon creation or updates of these properties.

Changes

Files Change Summary
components/hubspot/package.json Updated version from 0.11.0 to 0.12.0.
components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs Added new source component for monitoring changes to custom object properties in HubSpot.

Assessment against linked issues

Objective Addressed Explanation
Enable monitoring of specific HubSpot fields for custom objects (#14945)

Possibly related PRs

  • Hubspot version update #14816: This PR updates the version of the @pipedream/hubspot package from 0.10.0 to 0.10.1, which is directly related to the version update in the main PR that changes the version from 0.11.0 to 0.12.0.
  • Hubspot - Update Deal #14891: This PR also updates the @pipedream/hubspot package's version from 0.10.1 to 0.11.0, which is relevant as it shows a sequence of version updates in the same package context.

Suggested labels

ai-assisted

Suggested reviewers

  • lcaresia

🐇 In the garden, I hop and play,
With new changes brightening the day.
A version updated, a source anew,
Monitoring fields, just for you!
In HubSpot's world, we leap and bound,
With every change, joy is found! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7cb480 and 4588c90.

📒 Files selected for processing (1)
  • components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f8e21e and c7cb480.

📒 Files selected for processing (2)
  • components/hubspot/package.json (1 hunks)
  • components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/hubspot/package.json

Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927 lgtm! Ready for QA!

@michelle0927 michelle0927 merged commit 7970203 into master Dec 16, 2024
11 checks passed
@michelle0927 michelle0927 deleted the issue-14945 branch December 16, 2024 16:02
@coderabbitai coderabbitai bot mentioned this pull request Dec 27, 2024
@elvnsbmtr
Copy link

elvnsbmtr commented Jan 6, 2025

The agency we are working with just sent us the following in reference to the "New Or Updated Custom Object Property" trigger: "this is specifically for new site objects where the live date has changed. This isn't checking for existing site records. I also ran a test with a site to make sure it was specific to new objects versus existing"

Goal: they're attempting to build a trigger that will fire anytime a live_date property is updated--- regardless of whether it's a newly created custom object record or an existing record where live_date property is updating.

@andrewjschuang
Copy link
Collaborator

The code is filtering for the hs_lastmodifieddate property.
It should be emitting events regardless of a new object or existing one.

Are they selecting the site_live property correctly?

@elvnsbmtr
Copy link

elvnsbmtr commented Jan 7, 2025

The code is filtering for the hs_lastmodifieddate property. It should be emitting events regardless of a new object or existing one.

Are they selecting the site_live property correctly?

Just confirmed the are selecting the right property (live_date).
Copy_of_NEW__HubSpot_Sites_Go_Live_to_Create_Chargebee_Subscription___Customer_-_Build_-_Pipedream

@andrewjschuang
Copy link
Collaborator

@vunguyenhung could you try to reproduce the issue above when you get the chance?

@michelle0927
Copy link
Collaborator Author

@andrewjschuang @vunguyenhung I tested this with a few different properties, and it's working correctly for me. @elvnsbmtr Are there any errors being displayed in the source logs?

@vunguyenhung
Copy link
Collaborator

Hey @michelle0927 @andrewjschuang @elvnsbmtr, it's working correctly on my side also. @elvnsbmtr could you try to click "Run Now" to see if new events emitted? Or else it would only emit new events every 15 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HubSpot
5 participants