-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Hubspot - New Custom Object Property Change #14977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe pull request includes an update to the version number of the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/hubspot/package.json
(1 hunks)components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- components/hubspot/package.json
...ents/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs
Outdated
Show resolved
Hide resolved
...ents/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927 lgtm! Ready for QA!
The agency we are working with just sent us the following in reference to the "New Or Updated Custom Object Property" trigger: "this is specifically for new site objects where the live date has changed. This isn't checking for existing site records. I also ran a test with a site to make sure it was specific to new objects versus existing" Goal: they're attempting to build a trigger that will fire anytime a live_date property is updated--- regardless of whether it's a newly created custom object record or an existing record where live_date property is updating. |
The code is filtering for the Are they selecting the |
Just confirmed the are selecting the right property (live_date). |
@vunguyenhung could you try to reproduce the issue above when you get the chance? |
@andrewjschuang @vunguyenhung I tested this with a few different properties, and it's working correctly for me. @elvnsbmtr Are there any errors being displayed in the source logs? |
Hey @michelle0927 @andrewjschuang @elvnsbmtr, it's working correctly on my side also. @elvnsbmtr could you try to click "Run Now" to see if new events emitted? Or else it would only emit new events every 15 minutes |
Resolves #14945
Summary by CodeRabbit
New Features
objectSchema
and theproperty
.Chores
@pipedream/hubspot
package from0.11.0
to0.12.0
.