[Notion] updated page trigger improvements

[andrewjschuang]

• save all properties compressed instead of each property hash in db
• implement changes array that exports the previous and the current values

Summary by CodeRabbit

• New Features

  • Updated the version of the Notion package to 0.2.0, indicating potential new functionality.
  • Introduced a new property includeNewPages for event emissions related to newly created pages.
  • Enhanced event emission logic for better detection of updated and newly created pages.

• Improvements

  • Streamlined the process for detecting changes in properties.
  • Simplified the storage of property values during updates.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Visit Preview		Sep 27, 2024 6:12pm
pipedream-docs	⬜️ Ignored (Inspect)			Sep 27, 2024 6:12pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Sep 27, 2024 6:12pm

[coderabbitai]

Walkthrough

The pull request introduces updates to the @pipedream/notion package, including a version increment in the package.json file and significant changes to the notion-updated-page source module. The updates involve the addition of a new property for event emissions, renaming of methods for clarity, and enhancements to the logic for detecting property changes, particularly distinguishing between updated and newly created pages.

Changes

File Path	Change Summary
components/notion/package.json	Version updated from "0.1.24" to "0.2.0"
components/notion/sources/updated-page.mjs	Version updated from 0.0.19 to 0.1.0; added includeNewPages property; renamed getProperties to getPropertiesToCheck; updated emitEvent method signature; enhanced logic for detecting property changes and event emissions.

Possibly related PRs

• Notion - updated page trigger fix #13972: Updates the version of the @pipedream/notion package in package.json, directly related to the version change in this PR.
• Notion - updated-page source improvements #14045: Modifies the notion-updated-page source and updates the version of the @pipedream/notion package, relevant to the changes in this PR.
• [Notion] updated page trigger fix #14116: Similar to previous PRs, updates the version of the @pipedream/notion package and modifies the notion-updated-page source, making it relevant to this PR.

Suggested labels

enhancement

Suggested reviewers

• michelle0927

Poem

In the garden where ideas grow,
A new version hops, with a joyful glow.
Pages updated, events now clear,
A rabbit's cheer for changes near!
With properties checked, and new ones to see,
Let's celebrate this code jubilee! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1d34c18 and 6a43f23.

📒 Files selected for processing (2)

• components/notion/package.json (1 hunks)
• components/notion/sources/updated-page/updated-page.mjs (6 hunks)

🔇 Additional comments (2)

components/notion/sources/updated-page/updated-page.mjs (2)

155-155: Check compatibility of structuredClone

The structuredClone function is relatively new and may not be supported in all Node.js environments. Verify that your runtime environment supports structuredClone or consider using an alternative for deep cloning.

You can check your Node.js version:

If the version is below 17.0.0, you can use a polyfill or a library like lodash.cloneDeep:

npm install lodash

And update the code:

import _ from "lodash";

const previousValue = _.cloneDeep(propertyValues[page.id]?.[propertyName]);

---

150-152: Verify the loop termination condition for correctness

The condition to break the loop may cause some updated pages to be skipped:

if (lastCheckedTimestamp > Date.parse(page.last_edited_time)) {
  break;
}

This could exit the loop before processing all relevant pages. Ensure that pages are sorted in descending order of last_edited_time so that this condition works as intended.

Confirm that the pages are correctly sorted:

[michelle0927]

LGTM!