Skip to content

Ana06/get-changed-files v2.3.0 Considers renamed modified files as modified #13043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

Ana06/get-changed-files v2.3.0 Considers renamed modified files as modified #13043

merged 2 commits into from
Jul 30, 2024

Conversation

@danhsiung
Copy link
Collaborator

@danhsiung danhsiung commented Jul 30, 2024 •
edited
Loading

This caused any renamed and modified files to get added to the list of files to publish twice, which resulted in a publishing error on the second try.

We will switch to just using added_modified, as renamed files that have not been modified shouldn't affect anything, and will probably cause a separate failure during PR checks.

WHY

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Actions workflow to streamline the handling of file change outputs, improving efficiency in processing modified files.

@danhsiung
Ana06/get-changed-files v2.3.0 Adds added_modified_renamed that inclu…
6d193b1 
…des renamed non-modified files and all files in added_modified

this caused any renamed and modified files to get added to the list of
files to publish twice, which results in a publishing error on the
second try.
@vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 7:16pm
pipedream-docs ⬜️ Ignored (Inspect) Jul 30, 2024 7:16pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 30, 2024 7:16pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2024 •
edited
Loading

Walkthrough

The recent changes simplify the processing of file outputs in a GitHub Actions workflow by consolidating multiple outputs related to file changes into a single variable. This adjustment reduces complexity and enhances efficiency while keeping the overall control flow intact.

Changes

Files Change Summary
.github/workflows/publish-components.yaml Consolidated file change outputs into one variable, streamlining processing of added and modified files.

Poem

In the garden of code where the bunnies play,
A single output brightens the day.
With files combined, the flow is neat,
Efficiency dances on little paws' feet! 🐇✨
Hoppy changes, oh what a sight,
In our workflow, everything feels right!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 43be82f and 6d193b1.

Files selected for processing (1)
  • .github/workflows/publish-components.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/publish-components.yaml (1)

67-67: LGTM! But verify the correctness of the new output.

The change to use steps.files.outputs.added_modified_renamed simplifies the logic and should help avoid duplication issues. Ensure that the new output is correctly generated and includes all necessary file changes.

@danhsiung
slight modification in that we should ignore renamed files that are not
69f0ccd 
modified. If a file is in fact renamed and not modified, it should cause
a different error during PR checks.

Also fixing for the TS build.
GTFalcao
GTFalcao approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d193b1 and 69f0ccd.

Files selected for processing (1)
  • .github/workflows/publish-components.yaml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/publish-components.yaml

@danhsiung danhsiung merged commit 92a3cdc into master Jul 30, 2024
@danhsiung danhsiung deleted the fix-duplicate-renamed-file-listing branch July 30, 2024 19:25
This was referenced Nov 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@GTFalcao GTFalcao GTFalcao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danhsiung @GTFalcao