Salesforce usability improvements

components/salesforce_rest_api/actions/add-contact-to-campaign/add-contact-to-campaign.mjs

@@ -1,52 +1,52 @@
-import salesForceRestApi from "../../salesforce_rest_api.app.mjs";
-import {
-  removeNullEntries, toSingleLineString,
-} from "../../common/utils.mjs";
+import salesforce from "../../salesforce_rest_api.app.mjs";
 import constants from "../../common/constants.mjs";
 
 export default {
   key: "salesforce_rest_api-add-contact-to-campaign",
   name: "Add Contact to Campaign",
-  description: toSingleLineString(`
-    Adds an existing contact to an existing campaign.
-    See [Event SObject](https://developer.salesforce.com/docs/atlas.en-us.228.0.object_reference.meta/object_reference/sforce_api_objects_campaignmember.htm)
-    and [Create Record](https://developer.salesforce.com/docs/atlas.en-us.228.0.api_rest.meta/api_rest/dome_sobject_create.htm)
-  `),
-  version: "0.0.6",
+  description: "Adds an existing contact to an existing campaign. [See the documentation](https://developer.salesforce.com/docs/atlas.en-us.228.0.object_reference.meta/object_reference/sforce_api_objects_campaignmember.htm)",
+  version: "0.1.0",
   type: "action",
   props: {
-    salesForceRestApi,
+    salesforce,
     campaignId: {
       propDefinition: [
-        salesForceRestApi,
-        "sobjectId",
+        salesforce,
+        "recordId",
         () => ({
-          objectType: constants.OBJECT_TYPE.CAMPAIGN,
+          objType: "Campaign",
+          nameField: "Name",
         }),
       ],
       label: "Campaign ID",
-      description: "ID of the Campaign to which this Lead is associated.",
+      description: "The Campaign to add a Contact to.",
     },
     contactId: {
       propDefinition: [
-        salesForceRestApi,
-        "sobjectId",
+        salesforce,
+        "recordId",
         () => ({
-          objectType: constants.OBJECT_TYPE.CONTACT,
+          objType: "Contact",
+          nameField: "Name",
         }),
       ],
       label: "Contact ID",
-      description: "ID of the Contact who is associated with a Campaign.",
+      description: "The Contact to add to the selected Campaign.",
     },
   },
   async run({ $ }) {
-    const data = removeNullEntries({
-      CampaignId: this.campaignId,
-      ContactId: this.contactId,
+    const {
+      salesforce, campaignId, contactId,
+    } = this;
+    const response = await salesforce.createObject({
+      $,
+      objectType: constants.OBJECT_TYPE.CAMPAIGN_MEMBER,
+      data: {
+        CampaignId: campaignId,
+        ContactId: contactId,
+      },
     });
-    const response = await this.salesForceRestApi
-      .createObject(constants.OBJECT_TYPE.CAMPAIGN_MEMBER, data);
-    response && $.export("$summary", "Successfully added contact to campaign");
+    $.export("$summary", `Successfully added contact (ID: ${contactId}) to campaign (ID: ${campaignId})`);
     return response;
   },
 };

components/salesforce_rest_api/actions/add-lead-to-campaign/add-lead-to-campaign.mjs

@@ -1,51 +1,52 @@
-import salesForceRestApi from "../../salesforce_rest_api.app.mjs";
-import {
-  removeNullEntries, toSingleLineString,
-} from "../../common/utils.mjs";
+import salesforce from "../../salesforce_rest_api.app.mjs";
 import constants from "../../common/constants.mjs";
 
 export default {
   key: "salesforce_rest_api-add-lead-to-campaign",
   name: "Add Lead to Campaign",
-  description: toSingleLineString(`
-    Adds an existing lead to an existing campaign.
-    See [Event SObject](https://developer.salesforce.com/docs/atlas.en-us.228.0.object_reference.meta/object_reference/sforce_api_objects_campaignmember.htm)
-    and [Create Record](https://developer.salesforce.com/docs/atlas.en-us.228.0.api_rest.meta/api_rest/dome_sobject_create.htm)
-  `),
-  version: "0.0.6",
+  description: "Adds an existing lead to an existing campaign. [See the documentation](https://developer.salesforce.com/docs/atlas.en-us.228.0.object_reference.meta/object_reference/sforce_api_objects_campaignmember.htm)",
+  version: "0.1.0",
   type: "action",
   props: {
-    salesForceRestApi,
+    salesforce,
     campaignId: {
       propDefinition: [
-        salesForceRestApi,
-        "sobjectId",
+        salesforce,
+        "recordId",
         () => ({
-          objectType: constants.OBJECT_TYPE.CAMPAIGN,
+          objType: "Campaign",
+          nameField: "Name",
         }),
       ],
       label: "Campaign ID",
-      description: "ID of the Campaign to which this Lead is associated.",
+      description: "The Campaign to add a Lead to.",
     },
     leadId: {
       propDefinition: [
-        salesForceRestApi,
-        "sobjectId",
+        salesforce,
+        "recordId",
         () => ({
-          objectType: constants.OBJECT_TYPE.LEAD,
+          objType: "Lead",
+          nameField: "Name",
         }),
       ],
       label: "Lead ID",
-      description: "ID of the Lead who is associated with a Campaign.",
+      description: "The Lead to add to the selected Campaign.",
     },
   },
   async run({ $ }) {
-    const data = removeNullEntries({
-      CampaignId: this.campaignId,
-      LeadId: this.leadId,
+    const {
+      salesforce, campaignId, leadId,
+    } = this;
+    const response = await salesforce.createObject({
+      $,
+      objectType: constants.OBJECT_TYPE.CAMPAIGN_MEMBER,
+      data: {
+        CampaignId: campaignId,
+        LeadId: leadId,
+      },
     });
-    const response = await this.salesForceRestApi.createObject("CampaignMember", data);
-    response && $.export("$summary", "Successfully added lead to campaign");
+    $.export("$summary", `Successfully added lead (ID: ${leadId}) to campaign (ID: ${campaignId})`);
     return response;
   },
 };

components/salesforce_rest_api/actions/common/base-create-update.mjs

@@ -0,0 +1,108 @@
+import { ConfigurationError } from "@pipedream/platform";
+import salesforce from "../../salesforce_rest_api.app.mjs";
+import { getAdditionalFields } from "../../common/props-utils.mjs";
+
+export const additionalFields = {
+  type: "object",
+  label: "Additional Fields",
+  description:
+      "Other fields to set for this record. Values will be parsed as JSON where applicable.",
+  optional: true,
+};
+
+export function getProps({
+  objType,
+  createOrUpdate = "create",
+  docsLink = "https://developer.salesforce.com/docs/atlas.en-us.object_reference.meta/object_reference/sforce_api_objects_concepts.htm",
+  showDateInfo = false,
+}) {
+  let { initialProps } = objType;
+  if (initialProps && createOrUpdate === "update") {
+    initialProps = Object.fromEntries(
+      Object.entries(initialProps).map(([
+        key,
+        value,
+      ]) => [
+        key,
+        {
+          ...value,
+          optional: true,
+        },
+      ]),
+    );
+  }
+
+  return {
+    salesforce,
+    ...showDateInfo && {
+      dateInfo: {
+        type: "alert",
+        alertType: "warning",
+        content: "Date fields should be a [valid date string](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date#date_time_string_format) or a Unix timestamp in milliseconds. Example values: `2022-01-15T18:30:00.000Z` or `1642271400000`.",
+      },
+    },
+    ...objType[createOrUpdate === "create"
+      ? "createProps"
+      : "updateProps"],
+    ...initialProps,
+    docsInfo: {
+      type: "alert",
+      alertType: "info",
+      content: `[See the documentation](${docsLink}) for more information on available fields.`,
+    },
+    useAdvancedProps: {
+      propDefinition: [
+        salesforce,
+        "useAdvancedProps",
+      ],
+    },
+  };
+}
+
+export default {
+  methods: {
+    getObjectType() {
+      return "";
+    },
+    getAdvancedProps() {
+      return {};
+    },
+    getAdditionalFields,
+    formatDateTimeProps(props = {}) {
+      // https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_valid_date_formats.htm
+      return Object.fromEntries(Object.entries(props).filter(([
+        , value,
+      ]) => value !== undefined)
+        .map(([
+          key,
+          value,
+        ]) => {
+          const numValue = Number(value);
+          const date = new Date(Number.isNaN(numValue)
+            ? value
+            : numValue);
+          if (Number.isNaN(date.valueOf())) {
+            throw new ConfigurationError(`Invalid date format for prop \`${key}\`. Please provide a valid date format.`);
+          }
+          return [
+            key,
+            date.toISOString(),
+          ];
+        }));
+    },
+  },
+  async additionalProps() {
+    const objectType = this.getObjectType();
+    if (!this.useAdvancedProps || !objectType) return {};
+
+    const fields = (await this.salesforce.getFieldsForObjectType(objectType));
+    const fieldNames = fields.map((f) => f.name);
+    const filteredProps = Object.fromEntries(Object.entries(this.getAdvancedProps()).filter(([
+      key,
+    ]) => fieldNames.includes(key) || key[0] === key[0].toLowerCase()));
+    return {
+      ...filteredProps,
+      additionalFields,
+    };
+  },
+};

components/salesforce_rest_api/actions/convert-soap-xml-to-json/convert-soap-xml-to-json.mjs

@@ -5,10 +5,17 @@ export default {
   key: "salesforce_rest_api-convert-soap-xml-to-json",
   name: "Convert SOAP XML Object to JSON",
   description: "Converts a SOAP XML Object received from Salesforce to JSON",
-  version: "0.0.5",
+  version: "0.0.6",
   type: "action",
   props: {
     salesforce_rest_api,
+    infoBox: {
+      type: "alert",
+      alertType: "info",
+      content: `This action is useful in conjunction with Salesforce Flow Builder, and is primarily used if Instant triggers are not working for your use case.
+\\
+[See the documentation](https://pipedream.com/apps/salesforce-rest-api#troubleshooting) for more details.`,
+    },
     xml: {
       type: "string",
       label: "XML Soap Object",
@@ -17,14 +24,14 @@ export default {
     extractNotificationOnly: {
       type: "boolean",
       label: "Extract Notifications Only",
-      description: "Extracts only the notification parts from the XML. Default: `true`.",
+      description: "Whether to extract only the notification parts from the XML. Default: `true`.",
       optional: true,
       default: true,
     },
     failOnError: {
       type: "boolean",
       label: "Fail on Error",
-      description: "If should fail on error when extracting notifications. Default: `false`.",
+      description: "Whether the action should fail if an error occurs when extracting notifications. Default: `false`.",
       optional: true,
       default: false,
     },
@@ -44,6 +51,7 @@ export default {
     try {
       const notifications = json.elements[0].elements[0].elements[0].elements
         .filter(({ name }) => name === "Notification");
+      $.export("$summary", "Successfully converted to JSON and extracted notifications");
       return {
         notifications,
       };