Skip to content

Conversation

jleifnf
Copy link

@jleifnf jleifnf commented Oct 3, 2023

The columns arg have been noted to deprecate since v5.8.
This PR updates both to_dataframe and arrow_to_dataframe functions as well as relevant tests.
May not need to test that TypeError stating columns was given.

@jleifnf jleifnf requested a review from justinGilmer October 3, 2023 01:39
@justinGilmer
Copy link

Looks great @jleifnf .

@justinGilmer justinGilmer merged commit 8c4fed5 into staging Oct 3, 2023
@justinGilmer justinGilmer deleted the to-dataframe-deprecate-columns branch October 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants