Skip to content

Use PHP7 typehints #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use PHP7 typehints #38

wants to merge 1 commit into from

Conversation

@Sam-Burns
Copy link
Contributor

@Sam-Burns Sam-Burns commented Aug 22, 2020

A suggestion to make better use of typehinting, now we are on PHP 7.3+

@Sam-Burns Sam-Burns force-pushed the typehints branch 2 times, most recently from a3824f4 to 74eb3b7 Compare August 22, 2020 21:45
@h4kuna
Copy link

h4kuna commented Jan 15, 2021 •
edited
Loading

Hello, why you don't use declare(strict_types=1);? I think if you don't define this declare, that the scalar types don't really strict.

@h4kuna h4kuna mentioned this pull request Jan 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sam-Burns @h4kuna