-
Notifications
You must be signed in to change notification settings - Fork 254
Version rubik pi image #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
samfreund
wants to merge
14
commits into
PhotonVision:main
Choose a base branch
from
samfreund:version-rubik-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Version rubik pi image #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
previously approved these changes
Oct 14, 2025
7eb8359
to
5b6f17c
Compare
Oof, I think this is gonna break. Why? Cause the QSC flasher expects the folder shipped in the tarball to match the tarballs name. 😭 |
ae11dd7
to
d24c0be
Compare
ef708ae
to
1a407d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rubik pi image didn't have a version previously, which we want to add so people can tell which one they downloaded. Should also help mitigate the caching issue with the Qualcomm Launcher. Note that the launcher requires the directory inside the tarball to be named the same as the tarball, which is why we do it like this.
Meta
Merge checklist: