[NFC] Invert AprilTag family default #2124
Open
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Turner <[email protected]>
github-actions
bot
added
the
backend
samfreund
previously approved these changes
Oct 13, 2025
|
I'm not sure this PR actually changes our behacior, does it? |
It doesn't, it just makes it more clear what our default values are. Arguably it provides some optimization, but idt that's significant. This is more just a readability change, which imo is a good thing. |
| TargetModel tagModel = TargetModel.kAprilTag36h11; | ||
| if (settings.tagFamily == AprilTagFamily.kTag16h5) { | ||
| // 2023 tag, 6in | ||
| tagWidth = Units.inchesToMeters(6.5); |
There was a problem hiding this comment.
This should be changed, I think
mcm001
changed the title
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch default tag family used in AprilTag pipeline. We already functionally changed the default in #1333 but since 2024 FIRST appears to have been using 36h11 so switching here seems to make sense as well.
Meta
Merge checklist: