Skip to content

Set the initial capacity of ArrayLists in getAllUnreadResults() #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Set the initial capacity of ArrayLists in getAllUnreadResults() #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions photon-lib/src/main/java/org/photonvision/PhotonCamera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,10 @@ public List<PhotonPipelineResult> getAllUnreadResults() {
verifyVersion();
updateDisconnectAlert();

List<PhotonPipelineResult> ret = new ArrayList<>();

// Grab the latest results. We don't care about the timestamps from NT - the metadata header has
// this, latency compensated by the Time Sync Client
var changes = resultSubscriber.getAllChanges();
List<PhotonPipelineResult> ret = new ArrayList<>(changes.size());
for (var c : changes) {
var result = c.value;
checkTimeSyncOrWarn(result);
Expand Down
3 changes: 1 addition & 2 deletions photon-targeting/src/main/java/org/photonvision/common/networktables/PacketSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ public String getInterfaceUUID() {
}

public List<PacketResult<T>> getAllChanges() {
List<PacketResult<T>> ret = new ArrayList<>();

// Get /all/ changes since last call to readQueue
var changes = subscriber.readQueue();

List<PacketResult<T>> ret = new ArrayList<>(changes.length);
for (var change : changes) {
ret.add(parse(change.value, change.timestamp));
}
Expand Down
Loading