-
Notifications
You must be signed in to change notification settings - Fork 1
[PER-10314] Make folder click show containing files #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 46.95% 47.05% +0.10%
==========================================
Files 372 372
Lines 11444 11494 +50
Branches 1896 1907 +11
==========================================
+ Hits 5373 5409 +36
- Misses 5882 5899 +17
+ Partials 189 186 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…f child router usage and ambigous routes
…n async and actually it would remove items that were just registering again
…e already part of an unlisted share
slifty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does all look great and thank you for the easy to review commits!
Some notes about commit messages though, inspired by the great guidance of https://cbea.ms/git-commit/:
- These title lines are all are quite long (and wrap to the body) -- ideally subject is just 50 characters
- The issue number is in the subject, but we might want to consider putting this one line after the body <-- you aren't alone in doing this, but saves space for the subject line for content, while keeping the issue context in the commit overall.
- There is no body, for the most part (what goes in the body is a bit of an art, but generally explaining the "why does this commit exist" is the point.
So for instance you might consider a message like this
Add breadcrumbs for unlisted shares
Some unlisted shares have a folder tree structure. This commit adds
support for handling that case and also creating the navigation logic
within that tree structure.
Issue PER-10314 { title of the issue }
The properties router and isUnlistedShare were private members of the file-list component, but they are used in the template, so they needed to be made public. The code works, as it's javascript, but taking into account that we are using Typescript, we should be using the correct modifiers. Issue PER-10314 Implement folder in folder share preview for unlisted shares
STEPS TO TEST UNLISTED SHARES FLOW
Anonymous user:
Create an account or use an existing one and log in
Create or use a folder that contains other folders and files, inside the folders, create more folders, so you can have a tree structure like of folders and files.
Create share link for the "root" folder, the one you created first and make sure the link type is "Anyone can view"
Open a tab in incognito mode and paste the generated link
Go through folders by single clicking them
EXPECTED: Being able to navigate forward inside the folder structure.
In a folder with multiple files, click on a file
Use the arrows to go through all the files in the folder
Download one of the files
Click the back arrow
EXPECTED: It should get back to the containing folder
After you have clicked several folders, click a folder name in the breadcrumbs.
EXPECTED: The breadcrumbs cut to that specific folder and you get the see the folder/files inside it
Signed in user:
Repeat the steps above, only 4 changes:
4. Open a new tab and log in with a different user and then paste the generated link
STEPS TO TEST EXISTING SHARES FLOW:
Anonymous user:
EXPECTED: "Create account" modal should appear
Signed in user:
Repeat steps 1 through 3, then:
4. Open a new tab and log in with a different user and then paste the generated link
EXPECTED: "Accept share" sticky footer should appear.
OTHER FLOWS THAT HAVE BEEN AFFECTED BY THIS CHANGE
Private files/Shared files/Public files/Public gallery