Skip to content

DRAFT: Revert "op.c - work around Module::Install::DSL issue" #20234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

demerphq
Copy link
Collaborator

@demerphq demerphq commented Sep 3, 2022

This reverts commit 451a9a1 which added a workaround for Module::Install::DSL.

When we no longer need the Module::Install::DSL workaround we should merge this P and resolve Issue #20233.

@demerphq demerphq marked this pull request as draft September 3, 2022 08:37
@demerphq
Copy link
Collaborator Author

demerphq commented Sep 3, 2022

@karenetheridge when you have cleaned up the MI::DSL issue we can merge this and remove the icky workaround.

This reverts commit 451a9a1.

We no longer need the Module::Install::DSL workaround.

This fixes GH Issue #20233.
@demerphq demerphq force-pushed the yves/remove_mi_dsl_workaround branch from 2881d20 to f8ef6e8 Compare February 7, 2023 15:04
@demerphq
Copy link
Collaborator Author

demerphq commented Feb 8, 2023

@karenetheridge have you had a chance to fix MI yet? It would be nice to remove this special case behavior from the core.

@haarg
Copy link
Contributor

haarg commented Feb 8, 2023

Module::Install was fixed long ago. The problem is that when using Module::Install, a copy gets included with the released dist. So the broken versions of Module::Install will never go away until those dists get released again, either updating or replacing Module::Install. And anything that hasn't been fixed by now will never be fixed without someone taking over the modules.

@haarg
Copy link
Contributor

haarg commented Feb 13, 2023

I've checked dists that were broken when this was last discussed. None of them have been updated.

Distribution                       Date     Deps:  River Direct All
===================================================================
ADAMK-Release                      2013-12-17        0     0     0
App-Midgen                         2014-05-25        0     0     0
Archive-Builder                    2011-02-23        1     1     1
Aspect                             2013-04-09        2    10    13
Aspect-Library-Memoize             2011-05-26        0     0     0
Aspect-Library-NYTProf             2011-05-26        0     0     0
Aspect-Library-Profiler            2011-05-26        0     0     0
Aspect-Library-TestClass           2011-05-26        0     0     0
Aspect-Library-Timer               2012-10-31        0     0     0
Aspect-Library-Trace               2011-05-26        0     0     0
Business-AU-ABN                    2012-01-27        1     1     1
CPAN-Mini-Extract                  2012-10-31        1     1     1
CPAN-Mini-Visit                    2012-10-31        1     3     3
CPAN-WWW-Top100-Generator          2010-12-09        0     0     0
CPANDB                             2012-09-11        1     1     1
Chart-Math-Axis                    2011-03-24        1     3     3
Class-Autouse                      2012-02-03        2    13    24
Convert-EastAsianWidth             2010-11-07        0     0     0
Devel-Hints                        2010-11-10        1     1     1
Devel-Leak-Module                  2012-02-03        1     1     1
FBP                                2012-01-30        1     1     2
FBP-Demo                           2011-11-08        0     0     0
FBP-Perl                           2012-01-30        1     1     1
File-BLOB                          2011-11-08        0     0     0
File-Find-Rule-PPI                 2010-10-06        0     0     0
File-Find-Rule-VCS                 2010-10-06        1     3     4
GitHub-Extract                     2013-12-17        1     1     1
HTML-InfoVis                       2012-01-30        0     0     0
HTTP-Online                        2012-10-01        1     5     7
Imager-Search                      2011-05-29        0     0     0
JSAN-Client                        2010-06-24        1     2     2
JSAN-Shell                         2010-06-24        0     0     0
LWP-Online                         2011-07-08        2    43    86
Locale-Msgfmt                      2010-11-07        2    29    31
Module-Install-ORLite2Pod          2012-09-13        0     0     0
Module-Install-PerlTar             2010-07-26        0     0     0
MooseX-Atom                        2010-08-03        0     0     0
Net-CampaignMonitor                2013-05-08        0     0     0
Net-MySourceMatrix                 2011-06-15        0     0     0
ORDB-CPANMeta-Generator            2012-09-10        1     1     1
ORDB-CPANRT                        2011-10-31        0     0     0
ORDB-CPANRelease                   2011-11-08        0     0     0
ORDB-CPANTS                        2012-02-02        1     1     1
ORDB-CPANUploads                   2011-11-02        1     2     2
ORLite                             2012-09-30        2    10    24
ORLite-Migrate                     2012-02-02        1     2     2
ORLite-Mirror                      2012-10-31        2    13    16
ORLite-Pod                         2011-07-21        1     1     1
OpenGL-List                        2010-12-17        1     2     2
OpenGL-RWX                         2010-12-19        0     0     0
Oz                                 2011-05-24        0     0     0
PITA                               2011-10-27        1     1     1
PITA-Image                         2011-10-27        1     1     2
PITA-Scheme                        2011-02-01        1     2     3
PITA-XML                           2013-04-09        1     3     4
POE-Declare                        2012-02-03        1     6     7
POE-Declare-HTTP-Client            2011-04-16        1     3     4
POE-Declare-HTTP-Online            2011-04-16        1     1     1
POE-Declare-HTTP-Server            2011-03-08        1     2     3
POE-Declare-Log-File               2011-07-14        1     1     1
Padre-Plugin-Autodia               2013-11-08        0     0     0
Padre-Plugin-FormBuilder           2012-01-23        0     0     0
Padre-Plugin-Git                   2013-09-15        0     0     0
Padre-Plugin-Nopaste               2013-09-25        1     1     1
Padre-Plugin-SpellCheck            2013-09-24        0     0     0
Padre-Plugin-Swarm                 2011-11-15        1     1     1
Padre-Plugin-YAML                  2013-10-09        0     0     0
Perl-Shell                         2010-02-20        0     0     0
Process                            2011-10-27        2    10    12
RT-Extension-MandatoryFields       2013-06-07        0     0     0
RT-Extension-ReferenceIDoitObjects 2017-01-05        0     0     0
SDL-Tutorial-3DWorld               2011-01-19        0     0     0
SMS-Send                           2011-11-09        2    66    76
Test-POE-Stopping                  2011-05-31        1     6     8
Text-FindIndent                    2015-12-26        1     1     1
Xtract                             2011-11-07        1     2     2
YAML-Tiny-Stream                   2011-04-12        0     0     0
YiJing                             2010-12-12        0     0     0
pler                               2010-11-29        0     0     0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasConflicts type-core type-core-followup Core issues that need a follow up at some point.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants