Fix: 'MongodumpThread' object has no attribute 'client_cert_file' #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvaillancourt
approved these changes
Oct 26, 2017
|
Blocked by #238. This will fix the Travis CI failure blocking this PR |
|
Hi @carl-peng, Unfortunately a new flake8 code quality check is blocking your change in Travis-CI. Our build checks flake8 each build. I've fixed this new flake8 error in #238, however this means you'll need to merge master into your branch to get this fix. Could you do that please? This can be done in your branch's checkout with:
Once Travis-CI passes this can be merged. Thanks! Tim |
|
hi, Tim, Carl |
|
This looks good now, thanks @carl-peng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong ssl flag to avoid always fail in 'object has no attribute 'client_cert_file' when try connect to an MongoDB with SSL