Skip to content

Handle mkdir in State.py properly #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2017
Merged

Handle mkdir in State.py properly #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a7b8a9
Mkdir non-recursive if recursive mkdir fails
timvaillancourt May 18, 2017
1873d42
Reverse the logic
timvaillancourt May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mongodb_consistent_backup/State.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from time import time

from mongodb_consistent_backup.Common import Lock
from mongodb_consistent_backup.Errors import OperationError


class StateBase(object):
Expand All @@ -22,7 +23,14 @@ def __init__(self, base_dir, config, filename="meta.bson", state_version=1, meta
self.lock = Lock(self.state_lock, False)

if not os.path.isdir(self.state_dir):
os.makedirs(self.state_dir)
# try normal mkdir first, fallback to recursive mkdir if there is an exception
try:
os.mkdir(self.state_dir)
except:
try:
os.makedirs(self.state_dir)
except Exception, e:
raise OperationError(e)

def merge(self, new, old):
merged = old.copy()
Expand Down