Fix #43: Infinite loading tables #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.$el.offsetTop` will always evaluate to 0 when `this.$el` is inside a `td` (but the scrolling element is a `table`). This PR fixes the issue by explicitly calculating the top offset of `this.$el`, relative to the actual scrolling element, and not just the direct parent. I tried to see if `this.$el.offsetTop` will be updated by just setting CSS `position` to `relative` on `tr`, `td`, and `this.$el`, and all combinations, but no luck there. The performance hit of this PR will be an extra `getBoundingClientRect` call for `this.$el`.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 100% 96.49% -3.51%
==========================================
Files 1 1
Lines 56 57 +1
Branches 12 12
==========================================
- Hits 56 55 -1
- Partials 0 2 +2
Continue to review full report at Codecov.
|
Owner
|
Very clean and neat way, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.$el.offsetTopwill always evaluate to 0 whenthis.$elis inside atd(but the scrolling element is atable). This causes thedistanceto keep decreasing and the component continuously callsonInfinite.This PR fixes the issue by explicitly calculating the top offset of
this.$el, relative to the actual scrolling element, and not just the direct parent.I tried to see if
this.$el.offsetTopwill be updated by just setting CSSpositiontorelativeontr,td, andthis.$el, and all combinations, but no luck there. The performance hit of this PR will be an extragetBoundingClientRectcall forthis.$el.