Skip to content

pat validation: also check depending date #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2022
Merged

pat validation: also check depending date #971

merged 2 commits into from
Mar 9, 2022

Conversation

thet
Copy link
Member

@thet thet commented Mar 7, 2022

Fixes: #970

@thet thet marked this pull request as draft March 7, 2022 08:41
@thet thet force-pushed the 970-pat-validation branch from 28a5506 to 2ed4ded Compare March 9, 2022 08:52
thet added 2 commits March 9, 2022 11:02
@thet
maint(pat tabs): Fix test for error not thrown.
5982bd3 
Fix an asynchronous test which checks for an error not to be thrown.
The problem popped up in node version 16 and was passing in node version 14.

The error was:
```
 RUNS  src/pat/tabs/tabs.test.js
node:internal/process/promises:265
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "TypeError: Cannot read properties of undefined (reading 'jquery')".] {
  code: 'ERR_UNHANDLED_REJECTION'
}
```
@thet
fix(pat validation): With depending date validation also validate the…
2fa54cf 
… dependend date.

Fixes: #970
@thet thet force-pushed the 970-pat-validation branch from 2ed4ded to 2fa54cf Compare March 9, 2022 10:03
@thet thet changed the title quickfix: update depending date. pat validation: also check depending date Mar 9, 2022
@thet thet marked this pull request as ready for review March 9, 2022 10:05
@thet thet merged commit 3bc93f5 into master Mar 9, 2022
@thet thet deleted the 970-pat-validation branch March 9, 2022 10:06
@thet thet mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in date validation
1 participant
@thet