Revert "Do not apply filter, if filter is empty.", as this leads to unexpected UX.

[thet]

Commit was made due to no events shown in a calendar without filters
applied.
The real fix is to not include any filtering controls.
The code already supports showing all events when no filtering controls
are available.

Revert "pat-calendar: Do not apply filter, if filter is empty."

This reverts commit 2acb2c7.

[cornae]

So does that mean that te problem is maybe in the HTML and not in the .js? By default, all calendars should be ticked in the HTML.

…

Op 8 mrt. 2021, om 11:30 heeft Johannes Raggam ***@***.***> het volgende geschreven: Commit was made due to no events shown in a calendar without filters applied. The real fix is to not include any filtering controls. The code already supports showing all events when no filtering controls are available. Revert "pat-calendar: Do not apply filter, if filter is empty." This reverts commit 2acb2c7 <2acb2c7>. You can view, comment on, or merge this pull request online at: #814 <#814> Commit Summary Revert, as this leads to unexpected UX. File Changes M src/pat/calendar/calendar.js <https://github.com/Patternslib/Patterns/pull/814/files#diff-87d38bebfe694f18a3059aeb41ae731b1885e3c16e0a4040dfd16f2618c07803> (11) Patch Links: https://github.com/Patternslib/Patterns/pull/814.patch <https://github.com/Patternslib/Patterns/pull/814.patch> https://github.com/Patternslib/Patterns/pull/814.diff <https://github.com/Patternslib/Patterns/pull/814.diff> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#814>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFUKKP47YMNLOIB2UC4FJDTCSRLFANCNFSM4YZENUQQ>.

[thet]

The absences app do not have any filters, but in the html layout a hidden checkbox is present. That did not match with any of the absences, so no absences were show in the calendar.

The problem was:

• The commit which I'm reverting here - had the effect that if no checkboxes are checked, the filter is not applied and no events are shown.
• There is a change necessary in ploneintranet.prototype as well as quaive.app.absences. It removes the hidden filter checkbox, so that the pattern doesn't apply any filters. The hidden filter would show all events with the css class "cal-cat-all", which our events do not have yet.

I'll finish the PRs and will ping you again!

[cornae]

Op 8 mrt. 2021, om 11:43 heeft Johannes Raggam ***@***.***> het volgende geschreven: The absences app do not have any filters, but in the html layout a hidden checkbox is present. That did not match with any of the absences, so no absences were show in the calendar. The problem was: The commit which I'm reverting here - had the effect that if no checkboxes are checked, the filter is not applied and no events are shown.

It’s correct that if no checkbox are checked, that no events are shown. That’s the intended behaviour.

There is a change necessary in ploneintranet.prototype as well as quaive.app.absences. It removes the hidden filter checkbox, so that the pattern doesn't apply any filters. The hidden filter would show all events with the css class "cal-cat-all", which our events do not have yet.

I can’t judge about that because I don’t know the details of the implementation. From the design standpoint I can only say the tick boxes should be ticked by default until the user unticks one or more.

…

I'll finish the PRs and will ping you again! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#814 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFUKKJ57RMQYQTIMNRPGOTTCSS5TANCNFSM4YZENUQQ>.

[thet]

@cornae plz check this PR: https://github.com/quaive/ploneintranet.prototype/pull/1238