fix(pat-inject): Fix pat-inject to not break complex JSON pattern options. #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Rework the html rebasing to fix up relative URLs in pat-inject for a simpler and slightly more efficient method to walk over all attributes which need rebasing. The old method could destroy complex JSON based pattern options, like those from pat-structure in Mockup. Note: Only one rebase attribute per tag is currently possible. 1) This is the same as before. 2) We don't need more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This fixes a problem with Mockup injections of pat-structure.
Rework the html rebasing to fix up relative URLs in pat-inject for a simpler and slightly more efficient method to walk over all attributes which need rebasing.
The old method could destroy complex JSON based pattern options, like those from pat-structure in Mockup.
Note: Only one rebase attribute per tag is currently possible. 1) This
is the same as before. 2) We don't need more.