Separate modernizr #1115
Merged
Separate modernizr #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
separate-modernizr
branch
2 times, most recently
from
77165b0 to
6bc51ca
Compare
Since Patternslib 9.0.0-alpha.0 where we introduced webpack module federation for our bundles, Modernizr is loaded asynchronously and applying it's CSS classes a tick too late. For example, the change from the `no-js` to the `js` class was done while the tiles have already been drawn and visible on the screen, resulting in screen flickering. There are a number of projects which depend on Modernizr being applied early. This change now fixes the problem by separating the Modernizr build from the Patternslib bundle. If you depend on Modernzir, please include the new `modernizr.min.js` bundle in a script tag, preferably before the Patternslib bundle `bundle.min.js`. The global switch "window.__patternslib_disable_modernizr" is also removed, as it got useless.
Remove unnecessary tests in .modernizrrc.js and slim down the build size.
Do not use an webpack entry to build the modernizr bundle with an webpack runtime overhead. Instead, build it directly but abusing the webpack CopyPlugin transform mechanism. We could also build the modernizr bundle from the Makefile but that wouldn't provide the file when watching or when running webpack-dev-server.
thet
force-pushed
the
separate-modernizr
branch
from
6bc51ca to
2bc52dd
Compare
This was referenced Dec 19, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.