Bundle generation optimizations #1089
Merged
+298
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid code linting problem and make clear the init method is/can be asynchronous.
Add "is_input" to test if a element is of input type.
This is basically the same as $(":input") from Sizzle/jQuery.
…-inject. Wait a tick before registering the markdown type handler for pat-inject. With that there is no need for pat-inject to be imported before pat-markdown, as long as it is imported side by side with pat-markdown.
Only register the markdown data type handler when the pattern is available. Not hard-depending and importing pat-markdown fixes a problem where only including pat-tooltip also included pat-markdown and pat-syntax-highlight with it's big highlight.js library. This can reduce the generated bundle size significantly.
Only highlight code blocks when the pattern is available. Not hard-depending and importing pat-syntax-highlight fixes a problem where only including pat-markup also included pat-syntax-highlight and it's big highlight.js library. This can reduce the generated bundle size significantly.
Fix a typo where all languages were registered as "javascript".
Change the import so that no language is included by default. Instead import the languages dynamically. This reduces the download size when pat-syntaax-highlight is used significantly.
thet
force-pushed
the
thet-optimizations
branch
from
6dec1f8 to
c34d4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this PR fixes a problem where including e.g. pat-tiptap which depends on pat-tootip also includes pat-markdown and pat-syntax-highlight with all the language definitions. This makes the generated bundle huge and creates a suboptimal situation for module federation bundles. Because I want to add the generated bundles to npm packages directly, so that they can be used via unpkg or jsdelivr CDN services. Therefore I'd like to have small bundles and not upload dozens of MB to npm and pollute node_modules directories unnecessarily.
Note: what is not used is not downloaded, so this PR solves not a runtime problem. Except for this one commit except for the one commit where:
Loading of pat-syntax-highlight is optimized - before all languages were bundled into the highlight.js chunk, now each language is loaded on demand.