Parser should not create/overwrite global variables

[durko]

In parser.js _cleanupOptions writes to the global variable target for some reason. Is this intentional and really necessary?

We have a use case where Patterns dies in IE8 when it tries to write to the already existing target object.

[wichert]

target is not a global variable in _cleanupOptions: it is declared as a local variable in the second line of the function:

        _cleanupOptions: function(options) {
            var keys = Object.keys(options),
                i, spec, name, target;

If it wasn't declared as a local variable jshint would also report an error.

Can you provide more information about the error you see on IE8? Does it happen inside the parser or elsewhere?

[durko]

Ah, that issue was fixed very recently after the 1.2 split. The fix is still missing in the maint-v1.2 branch which we are working on. Can you merge it into this branch?

[wichert]

Done. Can you confirm that this works? If so I'll make a new 1.2.1 release today.