Fix Howlcrack causing inf DPS with Generals Cry #8889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Howlcrack unique item sets the cooldown of warcies to 0 causing the GC dps to explode into infinity due to division by zero. This was caused by the assumption that the mirages instantly spawn and attack. This commit makes it so that the cooldown is at least the amount of time it takes to spawm them all and attack or channel for 1s.
The env used by mirage skills is often modified causing the resulting env to differ. This has not caused issues to there not beign any caching use after calcMirages but this could come up in the future. Marking the env as CALCULATOR still allows for the env to be cached in case it's really needed but it will prevent it being used in most cases.
This was once used as the main table holding the cached output of skills. It has been entirely replaced by the remaining tables.
LocalIdentity
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8842
Based on and supersedes #8881
Description of the problem being solved:
The Howlcrack unique item sets the cooldown of warcies to 0 causing the GC dps to explode into infinity due to division by zero. This was caused by the assumption that the mirages instantly spawn and attack. This PR makes it so that the cooldown is at least the amount of time it takes to spawm them all and attack or channel for 1s.
Additionally some cleanup was done to minor aspects of mirages and caching.
Steps taken to verify a working solution: