Skip to content

expose SFTPHandle.closed for IOBase API #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

expose SFTPHandle.closed for IOBase API #223

wants to merge 1 commit into from

Conversation

MartinNowak
Copy link

@MartinNowak MartinNowak commented Aug 28, 2025 •
edited
Loading

@MartinNowak MartinNowak requested a review from pkittenis as a code owner August 28, 2025 14:22
@pkittenis
Copy link
Member

Hello,

Thanks for the interest.

What is this PR for? SFTPHandle.closed is already a public attribute.

@MartinNowak
Copy link
Author

MartinNowak commented Sep 3, 2025 •
edited
Loading

What is this PR for? SFTPHandle.closed is already a public attribute.

The cdef bint closed attribute does not seem to be visible on the Python side, preventing certain usages of an SFTPHandle as file. Also apparently cpdef does not support bint attribute.

import ssh2.sftp_handle
ssh2.sftp_handle.SFTPHandle(None).closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkittenis pkittenis Awaiting requested review from pkittenis pkittenis is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinNowak @pkittenis