-
Notifications
You must be signed in to change notification settings - Fork 295
refactor: change ResponseSamples to CodeSamples #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change ResponseSamples to CodeSamples #1162
Conversation
665d732 to
4793355
Compare
|
Visit the preview URL for this PR (updated for commit 4793355): https://docusaurus-openapi-36b86--pr1162-3uqvkzkg.web.app (expires Fri, 11 Jul 2025 22:03:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
sserrata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hey @dsuket, @sserrata
and rebuilt them using:
When I start up my server locally, I'm getting:
I checked and the generated files still contain the Do you have any tip that would help me to fix it? |
fix: change label change tab label name of anyOf/oneOf build feat: refactor request and response example fix: primitive add build fix: Added handling for when there is no schema. feat: Add new endpoints for allOf with nested array items and properties in OpenAPI schema [Enhancement] Add vendor extension support for positioning sidebar items (PaloAltoNetworks#1160) * Add support for x-position vendor extension and sorting logic * Add position and x-position types chore: restrict workflows to main repo (PaloAltoNetworks#1169) docs: fix typos and tables (PaloAltoNetworks#1170) Change the tab label of anyOf/oneOf (PaloAltoNetworks#1167) * feat: support null type * fix: fix tab label refactor: refactor request and response example (PaloAltoNetworks#1161) * feat: refactor request and response example * fix: primitive refactor: change ResponseSamples to CodeSamples (PaloAltoNetworks#1162)
Description
To use
ResponseSamplesnot only for responses but also for requests, I’m renaming it to a more general, shared name.Motivation and Context
To address Issue #1158, I need to organize the example-related parts.
This is the second step toward that goal.
Ref: #1161
How Has This Been Tested?
npm run buildnpm run testScreenshots (if appropriate)
Types of changes
Checklist