Skip to content

[develop] fix the spelling mistake for programming guide #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

[develop] fix the spelling mistake for programming guide #493

merged 1 commit into from
Dec 17, 2018

Conversation

@tink2123
Copy link
Collaborator

@tink2123 tink2123 commented Dec 17, 2018

No description provided.

@tink2123 tink2123 changed the title Update programming_guide.md fix the type for programming guide Dec 17, 2018
@tink2123 tink2123 changed the title fix the type for programming guide [develop] fix the spelling mistake for programming guide Dec 17, 2018
shanyi15
shanyi15 approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanyi15 shanyi15 merged commit c93aa2a into develop Dec 17, 2018
@shanyi15 shanyi15 deleted the tink2123-patch-1 branch December 17, 2018 05:54
shanyi15 pushed a commit that referenced this pull request Dec 17, 2018
@tink2123 @shanyi15
Cherry-pick form develop to 1.2 (#499)
6e2aed8 
* fix the ref for api_guides

* update_book

* fix for python3 support (#488)

* fix for python3 support
test=develop

* test=develop

* backward.rst

* Update backward.rst

* Update programming_guide.md (#493)
@LYMingML
Copy link

LYMingML commented Jan 8, 2019

url linkpage missing

@shanyi15
Copy link
Contributor

shanyi15 commented Jan 8, 2019

url linkpage missing

thanks for replying, we have recorded this, and will fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shanyi15 shanyi15 shanyi15 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tink2123 @LYMingML @shanyi15