Skip to content

Conversation

@jczaja
Copy link
Contributor

@jczaja jczaja commented May 5, 2022

This is oneDNN RNN(GRU, LSTM) kernels architecture

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 5, 2022

Thanks for your contribution!

Copy link

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv
Copy link
Contributor

Hi, @baoachun could you please help merge this design doc PR. It is very good and clear explanation for GRU and I think it is a good reference for other RNN ops.

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented May 6, 2022

@Aganlengzi 可以帮忙合入一下哈。可以作为后面其他各类RNN op集成oneDNN 和oneDNN INT8在X86上的参考

Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit a21215e into PaddlePaddle:develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants