-
Notifications
You must be signed in to change notification settings - Fork 2.7k
added changed information to text element so we can mark it as inserted or deleted #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you please tell me why this was removed from v0.13.0 ? Is there any problem we can solve ... |
I guess at the time they did not have the time to include in 0.13 see possible extensions here http://datypic.com/sc/ooxml/t-w_CT_TrackChange.html |
OK I updated the ChangedElement Type to extend from TrackChange and also added the reader from docx and odt to detect tracking changes inside the document. |
*/ | ||
protected function readParagraph(XMLReader $xmlReader, \DOMElement $domNode, $parent, $docPart = 'document') | ||
{ | ||
protected function readParagraph(XMLReader $xmlReader, \DOMElement $domNode, $parent, $docPart = 'document') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the {
on the next line to make the build succeed.
It was not enough: |
@moromete since I cannot commit on your master branch I pulled your branch into another one and modified the code a bit. I also added unit tests to cover the new code. |
If you want to enable track changes on added text you can mark it as INSERTED or DELETED by a specific user at a given time: