Added Line element #253
Merged
Added Line element #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2014 16:44
|
@ivanlanin could you please take a look at this code ? I duplicated the writeStyle function from Image, because the function calls $this->getElementStyle and I needed to override this function. |
|
Another great enhancement! 👍 This will resolve #123 when we can draw rectangular etc. I'll work on the duplication. |
|
Thanks @ivanlanin I just commited a final try to resolve the Travis build errors. I renamed the writeStyle function to writeLineStyle, but I am not quite happy with it as a lot of code duplication is still present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Line element, such that straight lines can be added to a document. Includes arrow ends and line dashing.