Skip to content

Word2007 Reader : Support for table cell borders and margins #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Word2007 Reader : Support for table cell borders and margins #2454

merged 1 commit into from
Sep 7, 2023

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Aug 31, 2023 •
edited
Loading

Description

Add reading borders and margins for table cell in Word2007 reader.

About borders: http://www.datypic.com/sc/ooxml/e-w_tcBorders-1.html
About margins: http://www.datypic.com/sc/ooxml/e-w_tcMar-1.html

Based on PR #2351 by @kernusr

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@Progi1984 Progi1984 added this to the 1.2.0 milestone Aug 31, 2023
@Progi1984 Progi1984 mentioned this pull request Aug 31, 2023
Closed
3 tasks
@coveralls
Copy link

coveralls commented Aug 31, 2023 •
edited
Loading

Coverage Status

coverage: 81.49% (+0.02%) from 81.472% when pulling a33be2b on pr2351 into c17c4c7 on master.

@Progi1984 Progi1984 merged commit 8ab8d29 into master Sep 7, 2023
@Progi1984 Progi1984 deleted the pr2351 branch September 7, 2023 16:23
@Progi1984
Copy link
Member Author

Thanks @kernusr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Open XML (Word 2007+)
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Progi1984 @coveralls @kernusr