Skip to content

Conversation

@kernusr
Copy link
Contributor

@kernusr kernusr commented Nov 22, 2022

Description

In MS Word 2021 docx files save with empty w:val of w:vMerge when expected value "continue".

I made suggest a solution:
In method readStyleDefs for argument styleDefs add fifth parameter "default value". This will allow default values to be passed for empty attributes. For example in a cells

The problem is described here: #2330

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@Progi1984 Progi1984 added this to the v1.1.0 milestone Nov 29, 2022
@Progi1984 Progi1984 merged commit be49938 into PHPOffice:master Nov 29, 2022
@Progi1984
Copy link
Member

Thanks @kernusr for your contribution.

@kernusr kernusr deleted the read-empty-vmerge branch December 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants