Skip to content

Call static instead of self on protected method #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 23, 2022
Merged

Call static instead of self on protected method #2308

merged 5 commits into from
Nov 23, 2022

Conversation

@fbclol
Copy link
Contributor

@fbclol fbclol commented Oct 7, 2022 •
edited
Loading

Description

call static instead of self on protected method

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:08
@Progi1984 Progi1984 changed the title call static instead of self on protected method Call static instead of self on protected method Nov 23, 2022
@Progi1984 Progi1984 added this to the v1.1.0 milestone Nov 23, 2022
@Progi1984 Progi1984 merged commit 9658c12 into PHPOffice:master Nov 23, 2022
@Progi1984
Copy link
Member

Progi1984 commented Nov 23, 2022

Thanks @fbclol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fbclol @Progi1984