Skip to content

Language::validateLocale should pass with locale 'zxx'. #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Language::validateLocale should pass with locale 'zxx'. #1558

merged 1 commit into from
Jan 30, 2019

Conversation

efpapado
Copy link
Contributor

@efpapado efpapado commented Jan 28, 2019 •
edited by troosan
Loading

Description

libreoffice uses zxx as default language code. This PR updates the language code validation to accept this code.

Fixes #1298

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.542% when pulling 3c9fa2d on ramsalt:develop into 1956908 on PHPOffice:develop.

@troosan troosan added this to the v0.17.0 milestone Jan 30, 2019
@troosan troosan merged commit af31fc5 into PHPOffice:develop Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@efpapado @coveralls @troosan