Skip to content

Add "Plain Text" type to SDT (Structured Document Tags) #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 26, 2018
Merged

Add "Plain Text" type to SDT (Structured Document Tags) #1541

merged 4 commits into from
Dec 26, 2018

Conversation

morrisdj
Copy link
Contributor

@morrisdj morrisdj commented Dec 26, 2018 •
edited by troosan
Loading

Description

The specification for SDTs (Structured Document Tags) allows for these types:

  • plain text
  • rich text
  • date picker
  • combo box
  • drop-down list
  • image

Only date, combo box and drop-down list were previously implemented.

I have added the plain text type.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@troosan troosan added this to the v0.16.0 milestone Dec 26, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 94.539% when pulling dcf637d on morrisdj:develop into 575c553 on PHPOffice:develop.

@troosan troosan merged commit bbe517a into PHPOffice:develop Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@morrisdj @coveralls @troosan