For RTF writers, sizes should should never have decimals #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oat. This is specified in the spec, for example here : http://www.biblioscape.com/rtf15_spec.htm#Heading2 « The delimiter marks the end of an RTF control word, and can be one of the following : [...] * A digit or a hyphen (-), which indicates that a numeric parameter follows. The subsequent digital sequence is then delimited by a space or any character other than a letter or a digit. »
troosan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1493 fix, only page dimensions where rounded for RTF writers. But every numerical value should be rounded, as per the spec(v1.5, more recent versions say the same) :
This PR fixes that by rounding every numerical values used in formatting RTF documents (I hope i did not forget any value ...).
Checklist:
composer run-script check --timeout=0and no errors were reported