Skip to content

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Nov 17, 2018

Description

When setting the line spacing, 240 twips are being added by default. This should only be done when the lineRule is AUTO. In all other cases the actual value should be used.

Fixes #1505

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan troosan added this to the v0.16.0 milestone Nov 17, 2018
@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage decreased (-0.02%) to 94.799% when pulling 1a9ed02 on troosan:fix_non_auto_line_spacing into a44aee8 on PHPOffice:develop.

@troosan troosan changed the title Fix non auto line spacing Line spacing is wrong when using "exact" line spacing rule Nov 19, 2018
@troosan troosan merged commit af5a271 into PHPOffice:develop Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants