Add ability to pass a Style object to a Section element #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troosan
approved these changes
Dec 8, 2018
| $this->setDocPart($this->container, $this->sectionId); | ||
| $this->style = new SectionStyle(); | ||
| $this->setStyle($style); | ||
| if (null === $style) { |
There was a problem hiding this comment.
Can't you remove this check, and pass true in setNewStyle instead?
add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Element\Sectionseems to be the only element which doesn't allow you to set it's style with an object. This is a very small change that doesn't break BC, so that the style can be set with an object.It makes it much easier to test as a consumer, because you can assert the style is the exact same object that you passed in. Instead of having to assert that you passed in the correct magic array by testing each attribute on the
Style\Sectionobject.Checklist:
composer run-script check --timeout=0and no errors were reportedNote:
I have not updated the documentation because it doesn't say anything about using style objects for any element. I am happy to contribute to the docs to add it though.