Skip to content

Fix 7.x builds #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 29, 2017
Merged

Fix 7.x builds #1228

merged 9 commits into from
Dec 29, 2017

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Dec 27, 2017

Description

when running with PHP 7.0 or 7.1 we get warnings, this fixes this issue

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have run phpunit, phpcs, php-cs-fixer, phpmd
  • The new code is covered by unit tests
  • I have update the documentation to describe the changes

@troosan troosan merged commit b614497 into PHPOffice:develop Dec 29, 2017
@troosan troosan deleted the fix_7.x_builds branch December 29, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@troosan