Skip to content

Conversation

FBnil
Copy link

@FBnil FBnil commented Oct 27, 2017

Abstract:
This patch changes the reader in order to handle TargetMode="External"
Closes:
#1173

Explanation:

When reading from documents.xml.rels, we not often see external images, like this:
<Relationship Id="rId4" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/image" Target="https://somewhere/image.png" TargetMode="External"/>

The TargetMode needs to be read and understood, to NOT default to a ZIP container for type "image" if the image is external.
Failing to do so results in an InvalidImageException while reading the file.

@troosan
Copy link
Contributor

troosan commented Nov 5, 2017

@FBnil thanks for this, I manually did (almost) the same changes to avoid merge issues.

@troosan troosan closed this Nov 5, 2017
@FBnil FBnil deleted the allow_external_images branch November 5, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants