Skip to content

Conversation

phryneas
Copy link
Contributor

Hiho :)

This pull request adds the type MACROBUTTON to the Field class.
It also extends the Field class by the functions setFontStyle and getFontStyle.

To keep the old behaviour that all Field instances would be written with the w:noProof style, support for setNoProof and getNoProof was added to Styles\Font. The new Field::setFontStyle method automatically sets noProof to true to all FontStyles that are passed to it.

If you have any questions or comments, feel free to ask.

Regards,
Lenz

@phryneas phryneas changed the title Feature/macrobutton new Field type: MACROBUTTON Mar 15, 2017
@FBnil
Copy link

FBnil commented Oct 5, 2017

@phryneas Will you be fixing the issue mention by Scrutinizer? (the one with the missing function).
If you branched from develop a long time ago, you need to git fetch origin and git merge remotes/origin/develop to fetch the updated develop branch, then check what is up with the conflicting files.

@phryneas
Copy link
Contributor Author

phryneas commented Oct 6, 2017

I can take a look at it, but it will take a few weeks, extremely busy right now.

@troosan troosan added this to the v0.15.0 milestone Feb 19, 2018
@troosan
Copy link
Contributor

troosan commented Feb 19, 2018

@phryneas please have a look, I had some issues merging your changes so I rewrote them.
It is a bit different to match more with the way other fields (added since you created this PR) were implemented.

@troosan troosan changed the title new Field type: MACROBUTTON Add support for MACROBUTTON Field Feb 20, 2018
@troosan troosan merged commit 7fe32e6 into PHPOffice:develop Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants