Bug in TCPDF after PR #1983 and #1907

[oleibman]

Describe the Bug

The code for src/PhpWord/Writer/PDF/TCPDF.php defines function createExternalWriterInstance twice, causing the test suite to fail. PR #1983 introduced the second copy of the function. PR #1907 is responsible for the first version of the function. The functions are identical, except for a formatting problem in 1907.

Steps to Reproduce

Please provide a code sample that reproduces the issue.

Running the test suite fails because one of the tests fails due to the duplicated function.
The test which fails is PhpOffice\PhpWord\Writer\PDF\TCPDFTest::testConstruct.

Expected Behavior

Test suite should pass.

Current Behavior

What is the current behavior?
Test suite fails.

Context

Please fill in your environment information:

• PHP Version: all
• PHPWord Version: most recent, including updates through 2020-12-29.

[oleibman]

I have added a fix for this in PR #1814. However, you may want to fast-track a more targeted solution.

[oleibman]

There was a fix today ("fix formatting" - I cannot find a PR number). It fixed the formatting error, but left both duplicate functions intact, so was ineffective.

[oleibman]

After a fix today ("fix merge issue" - no PR number), TCPDF.php is now in good shape. Closing this issue.