Incorrect definition of bold text

[ursaevandrey]

<w:b w:val="0"/> don't display as bold text in MSWord, but when reading from docx file Style\Font::isBold() is true

• PHP version: 7.1.11
• PHPWord version: 0.14
  

[troosan]

indeed, problem is in PhpOffice\PhpWord\Reader\Word2007\AbstractPart->readStyleDef

as soon as the node exists it considers it to be true. It should actually check the value of the w:val attribute. It should only return trueif the attribute is not 0 or false.

Value should be read according to http://www.datypic.com/sc/ooxml/t-w_ST_OnOff.html

you could try out the following change

    private function readStyleDef($method, $attributeValue, $expected)
    {
        $style = $attributeValue;

        if (self::READ_SIZE == $method) {
            $style = $attributeValue / 2;
        } elseif (self::READ_TRUE == $method) {
            $style = $attributeValue == null || $attributeValue == '1' || $attributeValue == 'true' || $attributeValue == 'on';
        } elseif (self::READ_FALSE == $method) {
            $style = $attributeValue == '0' || $attributeValue == 'false' || $attributeValue == 'off';
        } elseif (self::READ_EQUAL == $method) {
            $style = $attributeValue == $expected;
        }

        return $style;
    }

[ursaevandrey]

@troosan Thank you for answer. I did my task another way (removed text formatting in MSWord). I didn't want modified code of your library, but I think this bugfix need to add in next version.