Skip to content

Conversation

@jaywilliams
Copy link
Contributor

If a file has invalid EXIF data, it can cause an division by zero warning to occur.

If a file has invalid EXIF data, it can cause an division by zero warning to occur.
@Miljar
Copy link
Collaborator

Miljar commented Feb 6, 2017

Hi Jay,

Thanks for your PR. Can you please provide a unit test for this?

@jaywilliams
Copy link
Contributor Author

I've added a unit test, but whenever I try to run any tests, I get a notice No tests executed!, so I'm unsure how to fully test my test.

@Miljar
Copy link
Collaborator

Miljar commented Feb 6, 2017

You should specify the configuration file to be used. In travis, it works like this:

php vendor/bin/phpunit -c phpunit.xml.dist

@jaywilliams
Copy link
Contributor Author

Thanks, Tom. I was able to run the unit tests, and can confirm that it works properly.

@Miljar
Copy link
Collaborator

Miljar commented Feb 6, 2017

Thanks Jay, will merge & release!

@Miljar Miljar merged commit e43cc30 into PHPExif:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants