UTF-8 checking and encoding param support for exiftool #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please check the coding standards |
Collaborator
|
Have you checked the 3rd commend here? http://php.net/manual/en/function.iptcparse.php |
Collaborator
|
ping? |
Contributor
Author
|
Sorry for the delay. I have no idea what the problem is now. I commited a few changes, but if I run a php code beutifier, it fixes much more than what I did (things that I did not touch). |
Contributor
Author
|
I'm not sure what the problem is with Travis CI. Can you help me out please? |
1 similar comment
FrivalszkyP
changed the title
…the setOptions method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like I f**ked up my last commit big time. I checked it against a couple other images and unfortunately it re-encoded some IPTC data that was already encoded as UTF-8. So I built in a more intelligent exception handling, and just to be sure, I added a RuntimeException just in case anybody runs into the same problem as I did. I'm attaching a couple of images for testing.
These cases should cover it. One gives a pure ASCII output, the other gives a valid and json_decodeable UTF-8 output, and one gives some kind of Unicode or I don't know output that has to be utf8_encoded just to be sure. The mb_check_encoding method leaves the ASCII and the UTF-8 alone and only bothers with the more "exotic" strings.