Ruleset: hard deprecate support for sniffs not implementing the Sniff interface
#891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
rodrigoprimo
approved these changes
Mar 25, 2025
…f` interface While sniffs which don't implement the `Sniff` interface, but do implement the `register()` and `process()` methods, will _work_, it should be considered strongly discouraged. This commit adds a new, non-blocking deprecation notice which will inform users if they are using a sniff which doesn't implement the `Sniff` interface. The intention is to remove support for sniffs which don't implement the `Sniff` interface in PHPCS 4.0. Includes tests. This commit executes step 3 to address issue 694..
jrfnl
force-pushed
the
feature/694-3-ruleset-deprecate-sniffs-not-implementing-interface
branch
from
04243a9 to
8529313
Compare
Member
Author
|
Rebased without changes before merging. |
fredden
approved these changes
Apr 14, 2025
jrfnl
deleted the
feature/694-3-ruleset-deprecate-sniffs-not-implementing-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While sniffs which don't implement the
Sniffinterface, but do implement theregister()andprocess()methods, will work, it should be considered strongly discouraged.This commit adds a new, non-blocking deprecation notice which will inform users if they are using a sniff which doesn't implement the
Sniffinterface.The intention is to remove support for sniffs which don't implement the
Sniffinterface in PHPCS 4.0.Includes tests.
This commit executes step 3 to address issue #694.
Suggested changelog entry
Added deprecation notices (hard deprecation) for:
PHP_CodeSniffer\Sniffs\Sniffinterface, which will no longer be supported in PHPCS 4.0.