Skip to content

Conversation

@yevdyko
Copy link
Contributor

@yevdyko yevdyko commented Aug 18, 2025

PR Type

  • πŸ› Bug Fix
  • ✨ New Feature
  • πŸ”¨ Code Refactor
  • πŸ“ Documentation Update
  • πŸ§ͺ Test Update
  • πŸ”§ Build/CI Update
  • 🧹 Chore
  • βͺ Revert

Description

This PR updates import paths based on the new module resolution settings defined in tsconfig from #521.

Proposed Changes

  • Update import paths

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Testing (please describe)

Tested the demo application locally and checked all sketches still run as expected. Also ran the test suite and all existing tests pass without changes.

Breaking Changes

  • Yes (please describe)
  • No

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My changes generate no new warnings

@yevdyko yevdyko requested a review from jamesrweb as a code owner August 18, 2025 22:49
@yevdyko yevdyko self-assigned this Aug 18, 2025
@github-actions
Copy link

Coverage report for commit: 7e53736
File: ./coverage/clover.xml

Cover β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” Freq.
   0% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  10% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  20% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  30% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  40% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  50% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  60% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  70% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  80% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  90% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
 100% β”‚ β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ β”‚ 100.0%
      β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
 *Legend:* β–ˆ = Current Distribution 
Summary - Lines: 100.00% | Methods: 100.00% | Branches: 91.30%
FilesLinesMethodsBranches
src/components
Β  Β ReactP5Wrapper.tsx100.00%100.00%100.00%
Β  Β ReactP5WrapperGuard.tsx100.00%100.00%72.73%
Β  Β ReactP5WrapperWithSketch.tsx100.00%100.00%88.89%
src/constants
Β  Β P5WrapperClassName.ts100.00%100.00%100.00%
src/contracts
Β  Β CanvasInstanceRef.ts100.00%100.00%100.00%
Β  Β InputProps.ts100.00%100.00%100.00%
Β  Β P5CanvasInstance.ts100.00%100.00%100.00%
Β  Β P5WrapperProps.ts100.00%100.00%100.00%
Β  Β P5WrapperPropsWithSketch.ts100.00%100.00%100.00%
Β  Β Sketch.ts100.00%100.00%100.00%
Β  Β SketchProps.ts100.00%100.00%100.00%
Β  Β WithChildren.ts100.00%100.00%100.00%
Β  Β Wrapper.ts100.00%100.00%100.00%
Β  Β WrapperRef.ts100.00%100.00%100.00%
Β  Β p5.ts100.00%100.00%100.00%
src
Β  Β main.tsx100.00%100.00%100.00%
src/utils
Β  Β createCanvasInstance.ts100.00%100.00%100.00%
Β  Β logErrorBoundaryError.ts100.00%100.00%100.00%
Β  Β propsAreEqual.ts100.00%100.00%100.00%
Β  Β removeCanvasInstance.ts100.00%100.00%100.00%
Β  Β updateCanvasInstance.ts100.00%100.00%100.00%
Β  Β withoutKeys.ts100.00%100.00%100.00%

πŸ€– comment via lucassabreu/comment-coverage-clover

@jamesrweb jamesrweb merged commit 8fa069e into master Aug 19, 2025
10 checks passed
@jamesrweb jamesrweb deleted the fix-paths branch August 19, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants