Add the ability for fallback UIs to be rendered if the sketch is ever undefined #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevdyko
reviewed
May 1, 2023
Contributor
yevdyko
left a comment
yevdyko
left a comment
There was a problem hiding this comment.
The code looks good, but I was wondering if this option should be described in README. @jamesrweb WDYT?
Member
Author
True. That's a good point, I'll update the docs and push later 🙏🏻 |
yevdyko
approved these changes
May 2, 2023
Contributor
yevdyko
left a comment
yevdyko
left a comment
There was a problem hiding this comment.
@jamesrweb Thanks for the feature and documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a fallback UI to be rendered if the sketch is ever undefined rather than purely returning
nulland thus rendering nothing although this will still be the default behaviour if no fallback is provided.