Skip to content

Update project dependencies #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

Update project dependencies #186

merged 3 commits into from
Sep 12, 2022

Conversation

@jamesrweb
Copy link
Member

@jamesrweb jamesrweb commented Sep 12, 2022

  • Dependency updates

Auto-generated by create-pull-request

@yevdyko
Copy link
Contributor

yevdyko commented Sep 12, 2022 •
edited
Loading

@jamesrweb it looks like we have to run the pnpm format command before creating a commit, right?

Here is the PR with a fix #187

@yevdyko yevdyko added the dependencies Pull requests that update a dependency file label Sep 12, 2022
@jamesrweb jamesrweb enabled auto-merge (squash) September 12, 2022 08:14
@jamesrweb
Copy link
Member Author

jamesrweb commented Sep 12, 2022 •
edited
Loading

@jamesrweb it looks like we have to run the pnpm format command before creating a commit, right?

Here is the PR with a fix #187

Yes, correct, nice catch! 🙏🏻

@jamesrweb
Copy link
Member Author

jamesrweb commented Sep 12, 2022

@yevdyko ready for review again.

yevdyko
yevdyko approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jamesrweb jamesrweb merged commit 3a4e8b8 into master Sep 12, 2022
@jamesrweb jamesrweb deleted the update-project-dependencies branch September 12, 2022 08:18
@yevdyko yevdyko requested review from a team and removed request for a team September 12, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yevdyko yevdyko yevdyko approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesrweb @yevdyko