Type updates and runtime error handling #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrweb
added
enhancement
help wanted
documentation
jamesrweb
commented
Aug 5, 2022
This was
linked to
issues
Aug 16, 2022
jamesrweb
force-pushed
the
type-updates-error-handling-guard
branch
from
7ab3698 to
78633b2
Compare
Update project types and add a guard wrapper to log an appropriate error message if no sketch is provided at runtime.
jamesrweb
force-pushed
the
type-updates-error-handling-guard
branch
from
78633b2 to
3d434bb
Compare
Member
Author
|
@yevdyko ready for review, no more changes will be made! When you get some time, take a look and let me know what you think 👀. |
yevdyko
approved these changes
Aug 27, 2022
Contributor
yevdyko
left a comment
yevdyko
left a comment
There was a problem hiding this comment.
Looks good to me @jamesrweb! Let's release these changes 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Fixes #176
Update project types and add a guard wrapper to log an appropriate error message if no sketch is provided at runtime.
Proposed Changes
Additional Notes (optional)
This PR is more of a proposal, please review and provide feedback as usual, happy for design / implementation suggestions if any come to mind for discussion!