fix(ios): improve bundle identifier detection and replacement #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithemely
commented
Apr 22, 2025
smithemely
commented
- fix: handle both quoted and unquoted bundle identifiers
- feat: implement smarter base identifier detection logic
- fix: properly preserve extensions with multiple segments
…edGuy#86) * fix: handle both quoted and unquoted bundle identifiers * feat: implement smarter base identifier detection logic * fix: properly preserve extensions with multiple segments
|
I tested the updated implementation with various bundle identifier patterns in real projects, and it works correctly. The solution now handles:
This fix ensures bundle identifiers are consistently renamed throughout the project file while maintaining the structure of complex extension identifiers. It's more robust than the previous implementation. |
|
I'll test this once I get some free time. Although I was thinking of adding an additional property where users can provide the old package name, so no need for any complex logic. |
OutdatedGuy
changed the title
OutdatedGuy
requested changes
Aug 29, 2025
* fix: use RegExp.escape to safely handle special characters * perf: deduplicate identifiers upfront with Set * feat: smart base detection by counting extensions * fix: correct character class with dash at end [A-Za-z0-9._-] * refactor: single replaceAllMapped for all identifier patterns
OutdatedGuy
reviewed
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.