-
Notifications
You must be signed in to change notification settings - Fork 93
Sonic Repo Setup #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonic Repo Setup #2348
Conversation
sparrowDom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the hardhat version comment looks good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2348 +/- ##
==========================================
+ Coverage 52.04% 53.62% +1.57%
==========================================
Files 82 82
Lines 4196 4196
Branches 1101 1101
==========================================
+ Hits 2184 2250 +66
+ Misses 2009 1943 -66
Partials 3 3 ☔ View full report in Codecov by Sentry. |
naddison36
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm happy for this to be merged
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: