Skip to content

Conversation

@shahthepro
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@github-actions
Copy link

github-actions bot commented Jan 9, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 45872da

sparrowDom
sparrowDom previously approved these changes Jan 9, 2025
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the hardhat version comment looks good.

@shahthepro shahthepro marked this pull request as ready for review January 9, 2025 17:00
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.62%. Comparing base (c02572b) to head (45872da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2348      +/-   ##
==========================================
+ Coverage   52.04%   53.62%   +1.57%     
==========================================
  Files          82       82              
  Lines        4196     4196              
  Branches     1101     1101              
==========================================
+ Hits         2184     2250      +66     
+ Misses       2009     1943      -66     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 mentioned this pull request Jan 10, 2025
6 tasks
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm happy for this to be merged

@shahthepro shahthepro merged commit 79f2ae3 into master Jan 10, 2025
18 of 19 checks passed
@shahthepro shahthepro deleted the shah/sonic-hardhat-setup branch January 10, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants