Skip to content

Add withdrawal event #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Add withdrawal event #2059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/contracts/strategies/NativeStaking/NativeStakingSSVStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,4 +261,8 @@ contract NativeStakingSSVStrategy is
"eth not from allowed contracts"
);
}

function wethWithdrawnToVault(uint256 _amount) internal override {
emit Withdrawal(WETH_TOKEN_ADDRESS, address(0), _amount);
}
}
12 changes: 11 additions & 1 deletion contracts/contracts/strategies/NativeStaking/ValidatorAccountant.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ abstract contract ValidatorAccountant is ValidatorRegistrator {
IWETH9(WETH_TOKEN_ADDRESS).deposit{ value: wethToVault }();
// slither-disable-next-line unchecked-transfer
IWETH9(WETH_TOKEN_ADDRESS).transfer(VAULT_ADDRESS, wethToVault);

wethWithdrawnToVault(wethToVault);

emit AccountingFullyWithdrawnValidator(
fullyWithdrawnValidators,
activeDepositedValidators,
Expand Down Expand Up @@ -162,6 +163,8 @@ abstract contract ValidatorAccountant is ValidatorRegistrator {
IWETH9(WETH_TOKEN_ADDRESS).transfer(VAULT_ADDRESS, ethRemaining);
activeDepositedValidators -= 1;

wethWithdrawnToVault(ethRemaining);

emit AccountingValidatorSlashed(
activeDepositedValidators,
ethRemaining
Expand Down Expand Up @@ -233,4 +236,11 @@ abstract contract ValidatorAccountant is ValidatorRegistrator {
// unpause since doAccounting was successful
_unpause();
}

/***************************************
Abstract
****************************************/

/// @dev allows for NativeStakingSSVStrategy contract to emit Withdrawal event
function wethWithdrawnToVault(uint256 _amount) internal virtual;
}